From e99e661b8d706c0cf1ec2968b9e0bd8f28704324 Mon Sep 17 00:00:00 2001
From: Eunwoo Choi <choi@eunwoo.dev>
Date: Mon, 10 Feb 2025 00:25:30 +0900
Subject: [PATCH] chore: don't show ad on no search result (#668)

* chore: don't show ad on no search result

* feat: add disabled prop to Advertisement component and update usage for search page

---------

Co-authored-by: soyoka <55011525+soy0ka@users.noreply.github.com>
---
 components/Advertisement.tsx |  5 ++++-
 pages/search.tsx             | 12 +++++++-----
 2 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/components/Advertisement.tsx b/components/Advertisement.tsx
index d276fd0..76cea2f 100644
--- a/components/Advertisement.tsx
+++ b/components/Advertisement.tsx
@@ -1,6 +1,8 @@
 import AdSense from 'react-adsense'
 
-const Advertisement: React.FC<AdvertisementProps> = ({ size = 'short' }) => {
+const Advertisement: React.FC<AdvertisementProps> = ({ size = 'short', disabled = false }) => {
+	if (disabled) return null
+
 	return (
 		<div className='py-5'>
 			<div
@@ -39,6 +41,7 @@ declare global {
 
 interface AdvertisementProps {
 	size?: 'short' | 'tall'
+	disabled?: boolean
 }
 
 export default Advertisement
diff --git a/pages/search.tsx b/pages/search.tsx
index 7f1bbd4..16b59da 100644
--- a/pages/search.tsx
+++ b/pages/search.tsx
@@ -1,12 +1,12 @@
 import { NextPage, NextPageContext } from 'next'
-import type { FC } from 'react'
 import dynamic from 'next/dynamic'
 import { ParsedUrlQuery } from 'querystring'
+import type { FC } from 'react'
 
-import { List, Bot, Server } from '@types'
+import { Bot, List, Server } from '@types'
+import { KoreanbotsEndPoints } from '@utils/Constants'
 import { get } from '@utils/Query'
 import { SearchQuerySchema } from '@utils/Yup'
-import { KoreanbotsEndPoints } from '@utils/Constants'
 
 const Hero = dynamic(() => import('@components/Hero'))
 const Advertisement = dynamic(() => import('@components/Advertisement'))
@@ -58,6 +58,8 @@ const SearchComponent: FC<{
 const Search: NextPage<SearchProps> = ({ botData, serverData, priority, query }) => {
 	if (!query?.q) return <Redirect text={false} to='/' />
 	const list: ('bot' | 'server')[] = ['bot', 'server']
+	const resultNotExists =
+		(!botData || botData.data.length === 0) && (!serverData || serverData.data.length === 0)
 	return (
 		<>
 			<Hero
@@ -67,7 +69,7 @@ const Search: NextPage<SearchProps> = ({ botData, serverData, priority, query })
 			/>
 			<Container>
 				<section id='list'>
-					<Advertisement />
+					<Advertisement disabled={resultNotExists} />
 					{(priority === 'server' ? list.reverse() : list).map((el) => (
 						<SearchComponent
 							key={el}
@@ -76,7 +78,7 @@ const Search: NextPage<SearchProps> = ({ botData, serverData, priority, query })
 							type={el}
 						/>
 					))}
-					<Advertisement />
+					<Advertisement disabled={resultNotExists} />
 				</section>
 			</Container>
 		</>